Support Kafka's ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG in PulsarKafkaConsumer. #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fkaConsumer. Apply onConsume in poll() before returning the ConsumerRecords, apply onCommit in doCommitOffsets() before committing all offsets. Also apply doc to reflect support for ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG.
…tors to include the specific interceptor name.
sijie
approved these changes
Mar 27, 2019
|
run cpp tests |
sijie
added
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivatio
Support Kafka's ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG in PulsarKafkaConsumer. close #1090
Apply onConsume in
poll()before returning the read ConsumerRecords, apply onCommit indoCommitOffsets()before committing all offsets.All exception during applying onConsume/onCommit will be catch and log a message at the WARN level, it won't interrupt the normal
poll()anddoCommitOffsets()process.Also update doc to reflect support for ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG.