Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Async State manipulation methods #3978

Merged
merged 3 commits into from
Apr 4, 2019

Conversation

srkukarni
Copy link
Contributor

Motivation

Current state manipulation methods in functions only have sync versions. This adds their async counterparts

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@srkukarni
Copy link
Contributor Author

run cpp tests

@srkukarni
Copy link
Contributor Author

run java8 tests

1 similar comment
@srkukarni
Copy link
Contributor Author

run java8 tests

@merlimat merlimat added this to the 2.4.0 milestone Apr 4, 2019
Copy link
Contributor

@jerrypeng jerrypeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srkukarni should we also do this for python?

@srkukarni
Copy link
Contributor Author

@jerrypeng python seems a little more involved, so restricted this to java only. We could probably do that in a future pr.

@srkukarni srkukarni merged commit 13f870c into apache:master Apr 4, 2019
@srkukarni srkukarni deleted the add_async_state_methods branch April 4, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants