[pulsar-storm] Fix NPE while emitting next tuple #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jai1
approved these changes
Apr 5, 2019
|
|
||
| while ((msg = failedMessages.peek()) != null) { | ||
| MessageRetries messageRetries = pendingMessageRetries.get(msg.getMessageId()); | ||
| if (messageRetries != null) { |
There was a problem hiding this comment.
Move this if statement to a separate function.
There was a problem hiding this comment.
I wouldn't much worry about it because this piece of code is not being reused and nextTuple anyway is calling emitNextAvailableTuple and I don't think we want to do another method call for this small logic.
|
|
||
| // messageRetries is null because messageRetries is already acked and removed from pendingMessageRetries | ||
| // then remove it from failed message queue as well. | ||
| failedMessages.remove(); |
There was a problem hiding this comment.
Add a debug log here, in case people complain that their messages are not delivered or redelivered.
There was a problem hiding this comment.
yes..let me add it.
jai1
approved these changes
Apr 5, 2019
sijie
approved these changes
Apr 8, 2019
|
run integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
[PulsarSpout] removes messages from pendingMessageRetries but it doesn't remove from the
failedMessagesqueue because of that PulsarSpout throws NPE while emitting next tuple