Fix Python functions state which is completely broken #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a python functions instance is started with state enabled, it crashes because the state client cannot connect to the state endpoints. This is because the state client is *never* given the state endpoints, so there's no way it ever could connect.
|
@aahmed-se (couldn't add as a reviewer, but please take a look) |
sijie
approved these changes
Apr 11, 2019
srkukarni
approved these changes
Apr 11, 2019
|
rerun java8 tests |
|
@ivankelly can we write a integration test for this? |
merlimat
pushed a commit
that referenced
this pull request
May 19, 2019
When a python functions instance is started with state enabled, it crashes because the state client cannot connect to the state endpoints. This is because the state client is *never* given the state endpoints, so there's no way it ever could connect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a python functions instance is started with state enabled, it
crashes because the state client cannot connect to the state
endpoints. This is because the state client is never given the state
endpoints, so there's no way it ever could connect.