Add labels to function statefulsets and services #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubernetes client version to the latest
jerrypeng
approved these changes
Apr 13, 2019
sijie
approved these changes
Apr 13, 2019
added 2 commits
April 12, 2019 20:17
sijie
pushed a commit
that referenced
this pull request
Jul 3, 2020
### Motivation Pulsar release 2.4.0 supports Adding labels to function statefulsets and services. The code is implemented but the doc is not updated accordingly. Here is the code update PR: #4038 Therefore, i make this PR to update docs for releases: master/2.5.2/2.5.1/2.5.0/2.4.2/2.4.1/2.4.0 ### Modifications Add a note in the doc "Setup: Configure Functions runtime" under the Pulsar Functions section
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
### Motivation Pulsar release 2.4.0 supports Adding labels to function statefulsets and services. The code is implemented but the doc is not updated accordingly. Here is the code update PR: #4038 Therefore, i make this PR to update docs for releases: master/2.5.2/2.5.1/2.5.0/2.4.2/2.4.1/2.4.0 ### Modifications Add a note in the doc "Setup: Configure Functions runtime" under the Pulsar Functions section (cherry picked from commit 4a04169)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation Pulsar release 2.4.0 supports Adding labels to function statefulsets and services. The code is implemented but the doc is not updated accordingly. Here is the code update PR: apache#4038 Therefore, i make this PR to update docs for releases: master/2.5.2/2.5.1/2.5.0/2.4.2/2.4.1/2.4.0 ### Modifications Add a note in the doc "Setup: Configure Functions runtime" under the Pulsar Functions section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Labels are of great use while selecting which kubernetes objects are targetted. This pr adds labels to the statefulsets and services created while launching functions.
Also upgraded the kubernetes client version to the latest
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation