-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tiered storage support for Pulsar SQL #4045
Conversation
@@ -625,10 +626,10 @@ public PulsarColumnHandle apply(PulsarInternalColumn pulsarInternalColumn) { | |||
|
|||
Schema schema = topicsToSchemas.get(topicSchemaName).getType() == SchemaType.AVRO ? AvroSchema.of(SchemaDefinition.<Foo>builder().withPojo(Foo.class).build()) : JSONSchema.of(SchemaDefinition.<Foo>builder().withPojo(Foo.class).build()); | |||
|
|||
org.apache.pulsar.shade.io.netty.buffer.ByteBuf payload = org.apache.pulsar.shade.io.netty.buffer.Unpooled | |||
io.netty.buffer.ByteBuf payload = io.netty.buffer.Unpooled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just use ByteBuf
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
rerun java8 tests |
rerun java8 tests |
1 similar comment
rerun java8 tests |
rerun cpp tests |
rerun integration tests |
Motivation
Add support for Pulsar SQL to be able to query offloaded ledgers