Fix: set receive queue size for sinks #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrypeng
added
type/bug
|
rerun cpp tests |
|
rerun java8 tests |
1 similar comment
|
rerun java8 tests |
jerrypeng
force-pushed
the
fix_sink_update_recv_queue_size
branch
from
0f70e92
to
260017d
Compare
|
rerun java8 tests |
merlimat
approved these changes
Apr 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the receiveQueueSize config does not get set according when creating or updating sinks.
Modifications
Fix the bug and also add tests.
This should also help stabilize the sink related tests in PulsarFunctionsE2ETest.
Will have another PR to stabilize the source related tests in PulsarFunctionsE2ETest.