Function use negative acknowledge #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will add tests for this |
|
tests added |
merlimat
added
the
type/enhancement
|
run cpp tests |
|
rerun java8 tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since negative acknowledgements were added to Pulsar, Pulsar functions should take advantage of this functionality. When a error, e.g. user exception, happens we should send a negative ack so that the message can be redelivered and reprocessed.
Currently, users will have set the ackTimeout config for messages to be redelivered when an error happens. This is cumbersome for users and hard to get right when process times vary
Also fixed a bug involving setting user and system exceptions, that was caught when writing integration tests for this