Revert dup consumer and related code #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit ee98e8b.
Revert "[cpp client] Bugfix prevent dup consumer for same topic subscription" Revert "[Issue apache#3226][cpp client] Prevent dup consumers on same client cnx" This reverts commit fff02e2. This reverts commit 762e0ab.
|
run java8 tests |
|
@lovelle thanks for doing this! There are some test failures. |
lovelle
force-pushed
the
revert_dup_consumer_and_related_code
branch
from
d8e5a51
to
36d3455
Compare
|
@jerrypeng Sorry, now fixed! |
sijie
approved these changes
Apr 28, 2019
jerrypeng
approved these changes
Apr 29, 2019
jiazhai
approved these changes
Apr 29, 2019
merlimat
approved these changes
Apr 29, 2019
merlimat
pushed a commit
that referenced
this pull request
May 19, 2019
* Revert "[cpp client] implement reference count for close() (#3863)" This reverts commit ee98e8b. * Revert Prevent dup consumers and refCount for cpp client Revert "[cpp client] Bugfix prevent dup consumer for same topic subscription" Revert "[Issue #3226][cpp client] Prevent dup consumers on same client cnx" This reverts commit fff02e2. This reverts commit 762e0ab. * Revert "Feature - implement reference count for ConsumerImpl (#3795)" This reverts commit ff4db8d. * Revert Prevent dup consumers and refCount for java client Revert "Prevent dup consumers on same client cnx with shared subscription" Revert "[java client] Bugfix prevent dup consumers for same topic subscribe" This reverts commit 231db03. This reverts commit fb5dcd9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts optimization to prevent duplicate consumers and all related code.