Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug of key_shared subscription(Message cannot be dispatched while a consumer crash) #4335

Merged
merged 1 commit into from
May 23, 2019
Merged

Fix bug of key_shared subscription(Message cannot be dispatched while a consumer crash) #4335

merged 1 commit into from
May 23, 2019

Conversation

codelipenghui
Copy link
Contributor

Motivation

Describe the bug
Use key_shared subscription, while a consumer crash, message cannot be dispatched correctly.

To Reproduce

  1. start consumer1
  2. start consumer2
  3. start consumer3
  4. send message
  5. close consumer1
  6. close consumer2

Expected behavior
Messages can also be received in full.

Actual behavior
Unable to receive part of messages that the range originally responsible for consumer2.

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

jiazhai
jiazhai approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@jiazhai jiazhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, good catch

@jiazhai jiazhai merged commit e50c829 into apache:master May 23, 2019
@jiazhai jiazhai added this to the 2.4.0 milestone May 23, 2019
@codelipenghui codelipenghui deleted the fix_key_shared_consumer_crash branch May 19, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@jiazhai jiazhai jiazhai approved these changes

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@codelipenghui codelipenghui

Labels
area/broker
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codelipenghui @sijie @jiazhai