Add circe source code to checksum library #44
Conversation
|
CLA is valid! |
| Hash Algorithm Framework & Library, which can be obtained at: | ||
|
|
||
| * LICENSE: | ||
| * licenses/LICENSE-2.0 (Apache License) |
There was a problem hiding this comment.
@merlimat : should we add any additional information under LICENSE.
There was a problem hiding this comment.
We can just mention :
LICENSE : Apache License, Version 2.0
rdhabalia
added
the
type/enhancement
| @@ -26,3 +26,12 @@ Google's data interchange format, which can be obtained at: | |||
| * license/LICENSE.protobuf.txt (New BSD License) | |||
There was a problem hiding this comment.
Actually.. this file we don't have it there :)
There was a problem hiding this comment.
yes. So, should we change it to LICENSE : Google Inc. or we can keep it as it is.
There was a problem hiding this comment.
We should add the protobuf license file as part of a separate PR
There was a problem hiding this comment.
I have added protobuf/LICENSE.protobuf.txt
| Hash Algorithm Framework & Library, which can be obtained at: | ||
|
|
||
| * LICENSE: | ||
| * licenses/LICENSE-2.0 (Apache License) |
There was a problem hiding this comment.
We can just mention :
LICENSE : Apache License, Version 2.0
|
|
||
| * LICENSE: | ||
| * licenses/LICENSE-2.0 (Apache License) | ||
| * Git: |
There was a problem hiding this comment.
sure. changed to:
- LICENSE : Apache License, Version 2.0
- HOMEPAGE:
|
I think we should also import unit tests |
|
imported unit-test cases after converting from junit to testng. |
| <artifactId>circe-crc</artifactId> | ||
| <version>1.1-20140603.044857-1</version> | ||
| <groupId>com.googlecode.jmockit</groupId> | ||
| <artifactId>jmockit</artifactId> |
There was a problem hiding this comment.
Shouldn't this be added to test scope?
There was a problem hiding this comment.
yes.. i missed one commit to push.. it's only required for test so, scope should be test. made the change.
* Introduce FunctionStats to collection function related stats * Format license headers
Fix compilation warning
In Pulsar repo, there was already a Protocol handler framework, This PR tries build KOP in a nar file, and to make KoP.nar runs as a Protocol handler for Pulsar.
Motivation
Pulsar-checksumusescircelibrary to compute checksum but it's release-binaries are not available. So, to avoid depending on snapshot version, import the source code of this library.Modifications
Import source classes from
circerepo which requires to compute crc32c checksum.Result
No functionality change. However, while building pulsar, it doesn't have to download circe binaries.