Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Key_Shared dispatch ordering of message redelivery. #4406

Merged
merged 1 commit into from
May 31, 2019
Merged

FIX Key_Shared dispatch ordering of message redelivery. #4406

merged 1 commit into from
May 31, 2019

Conversation

codelipenghui
Copy link
Contributor

Motivation

Ensure redelivery messages is ordered dispatch by key in Key_Shared subscription.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui self-assigned this May 30, 2019
@codelipenghui codelipenghui added this to the 2.4.0 milestone May 30, 2019
@codelipenghui codelipenghui mentioned this pull request May 30, 2019
Closed
12 tasks
@codelipenghui
Copy link
Contributor Author

relate to #4077

@codelipenghui
Copy link
Contributor Author

run Java8 Tests

@codelipenghui
Copy link
Contributor Author

run Java8 Tests

merlimat
merlimat approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label May 31, 2019
@merlimat merlimat merged commit 9db06a2 into apache:master May 31, 2019
@sijie sijie mentioned this pull request Dec 27, 2019
Closed
15 tasks
@codelipenghui codelipenghui deleted the fix_key_shared_redeliver_ordering branch May 19, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@jiazhai jiazhai jiazhai approved these changes

@sijie sijie Awaiting requested review from sijie

Assignees

@codelipenghui codelipenghui

Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codelipenghui @merlimat @jiazhai