[pulsar-broker] Fix race condition of read-timeout task in ML #4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
changed the title
|
rerun java8 tests |
|
rerun integration tests |
sijie
reviewed
Jun 4, 2019
| @Override | ||
| public void readEntryComplete(Entry entry, Object ctx) { | ||
| if (checkCallbackCompleted(ctx)) { | ||
| long reOpCount = (ctx != null && ctx instanceof Long) ? (long) ctx : 0; |
There was a problem hiding this comment.
I see this pattern is repeated many times. Can we abstract this logic into a common method or rewrite those methods using this pattern into one common method?
There was a problem hiding this comment.
sure.. made the change.
|
rerun java8 tests |
1 similar comment
|
rerun java8 tests |
sijie
approved these changes
Jun 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix race condition when read-timeout task and read-callback try to recycle same calback object. We will close #4434 once this fix is merged.