[pulsar-ml] handle race condition between timeout-task and add-call complete #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun java8 tests |
jai1
reviewed
Jun 4, 2019
| @@ -3080,12 +3080,11 @@ private void checkAddTimeout() { | |||
| OpAddEntry opAddEntry = pendingAddEntries.peek(); | |||
| if (opAddEntry != null) { | |||
| boolean isTimedOut = opAddEntry.lastInitTime != -1 | |||
| && TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() - opAddEntry.lastInitTime) >= timeoutSec | |||
| && opAddEntry.completed == FALSE; | |||
| && TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() - opAddEntry.lastInitTime) >= timeoutSec; | |||
There was a problem hiding this comment.
Don't understand why we removed opAddEntry.completed == FALSE
There was a problem hiding this comment.
we need atomic callback handler and want to make sure that OpAddEntry callback completes atomically. So, we replaced boolean completed with addOpCount so, we can update it atomically and only one thread (bk-client/timeout-task) succeed to process the callback.
jai1
reviewed
Jun 4, 2019
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java
Outdated
Show resolved
Hide resolved
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java
Outdated
Show resolved
Hide resolved
|
rerun java8 tests |
|
rerun java8 tests |
sijie
approved these changes
Jun 14, 2019
|
@jai1 can you review it again? |
merlimat
approved these changes
Jun 14, 2019
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
May 28, 2021
…completion - solution was added in apache#4455
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
May 29, 2021
…completion (apache#10740) - solution was added in apache#4455
wangjialing218
pushed a commit
to wangjialing218/pulsar
that referenced
this pull request
May 31, 2021
…completion (apache#10740) - solution was added in apache#4455
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2021
…completion (apache#10740) - solution was added in apache#4455 (cherry picked from commit 4372b49)
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…completion (apache#10740) - solution was added in apache#4455
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…completion (apache#10740) - solution was added in apache#4455
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Broker has addEntry operation-timeout task which can timeout Add-entry operation if it's not completed in configured time. So, addEntry operation can be completed by timeout-task or normal bk-client thread. This PR makes sure that addEntry task can be completed atomically by one thread only.