Refactoring Function Component implementation #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun cpp tests |
1 similar comment
|
rerun cpp tests |
|
This will bring conflict to #4627, mark this as 2.4.1 |
jiazhai
pushed a commit
that referenced
this pull request
Aug 28, 2019
* Refactoring Function Component implementation * cleaning up (cherry picked from commit 95df092)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The code for register and update of Sources, Sinks, and Functions are melded together and have become unwieldy. Continue to refactor more code from ComponentImpl to FunctionsImpl, SinksImpl, and SourcesImpl.
Change Functions, Sources, and Sinks register and update REST endpoints to take FunctionConfig, SourceConfig, and SinkConfig instead of a JSON String