Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 4636][pulsar-dashboard] Count distinct bundles #4637

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

rshermanTHG
Copy link
Contributor

Fixes #4636

Motivation

When looking at the Brokers page on the dashboard the number of bundles equalled the number of topics meaning 1 topic per bundle. This is incorrect.

Modifications

When counting the number of bundles set the distinct parameter to True.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Before this fix

WrongBundleCount

After this fix

FixedBundleCount

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat merged commit ce8f60a into apache:master Jun 28, 2019
@merlimat merlimat added this to the 2.4.1 milestone Jun 28, 2019
@merlimat merlimat added component/dashboard type/bug The PR fixed a bug or issue reported a bug labels Jun 28, 2019
jiazhai pushed a commit that referenced this pull request Aug 28, 2019
(cherry picked from commit ce8f60a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pulsar-dashboard]Dashboard Count of bundles on brokers page too high
2 participants