Improve and add authorization to function download and upload #4644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun java8 tests |
easyfan
pushed a commit
to easyfan/pulsar
that referenced
this pull request
Jul 26, 2019
…e#4644) * Improve and add authorization to function download and upload * cleaning up * fix bug
jiazhai
pushed a commit
that referenced
this pull request
Aug 28, 2019
* Improve and add authorization to function download and upload * cleaning up * fix bug (cherry picked from commit 20cf739)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the download and upload function endpoints do not have any authorization which allows any authenticated user to download or upload anything.
Modifications
For the existing download or upload endpoints, only allow superUsers be able to access these endpoints.
Add a download endpoint with authorization that allows users to download function package. The endpoint takes parameters tenant, namespace, and name. Then the latest function package will be returned.
Allow pulsar-admin to use that endpoint as well.
Change KubernetesRuntime to use that as well
Not sure why we have an upload endpoint. Not really used anywhere. We should probably just remove it in the future.