Fix: Add kubernetes namespace to function instance url #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrypeng
added
type/bug
|
@cckellogg please also take look |
cckellogg
reviewed
Jul 10, 2019
| @@ -993,6 +993,10 @@ private static String createJobName(String tenant, String namespace, String func | |||
| return "pf-" + tenant + "-" + namespace + "-" + functionName; | |||
| } | |||
|
|
|||
| private static String getServiceUrl(String jobName, String jobNamespace, int instanceId) { | |||
| return String.format("%s-%d.%s.%s", jobName, instanceId, jobName, jobNamespace); | |||
There was a problem hiding this comment.
Does there need to be svc.cluster.local after the namespace? https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/#namespaces-and-dns
There was a problem hiding this comment.
That format worked when I tested in minikube
There was a problem hiding this comment.
maybe by default "svc.cluster.local" is added on if not specified?
There was a problem hiding this comment.
lets add it since that is what is in the documentation
There was a problem hiding this comment.
Yeah I think either should work.
cckellogg
approved these changes
Jul 10, 2019
merlimat
approved these changes
Jul 10, 2019
|
retest this please |
|
run cpp tests |
sijie
approved these changes
Jul 21, 2019
easyfan
pushed a commit
to easyfan/pulsar
that referenced
this pull request
Jul 26, 2019
### Motivation Currently, if the kubernetes namespace set to deploy functions in is different than the one in which brokers/workers reside, get status and stats doesn't work because the url for instances does not specify the namespace.
jiazhai
pushed a commit
that referenced
this pull request
Aug 28, 2019
### Motivation Currently, if the kubernetes namespace set to deploy functions in is different than the one in which brokers/workers reside, get status and stats doesn't work because the url for instances does not specify the namespace. (cherry picked from commit 8c3445a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, if the kubernetes namespace set to deploy functions in is different than the one in which brokers/workers reside, get status and stats doesn't work because the url for instances does not specify the namespace.