[build] docker/publish.sh doesn't work for pulsar-all and pulsar-standalone images
#4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andalone images *Motivation* pulsar-all and pulsar-standalone dont tag correct as pulsar image. so it fails `docker/publish.sh` *Modifications* Tag no-repo for both latest and the release version for both pulsar-all and pulsar-standalone *Verify this change* After patching this change, `docker/publish.sh` works as expected.
merlimat
approved these changes
Jul 10, 2019
codelipenghui
approved these changes
Jul 11, 2019
jiazhai
approved these changes
Jul 11, 2019
|
retest this please |
|
run java8 tests |
2 similar comments
|
run java8 tests |
|
run java8 tests |
easyfan
pushed a commit
to easyfan/pulsar
that referenced
this pull request
Jul 26, 2019
…andalone images (apache#4705) *Motivation* pulsar-all and pulsar-standalone dont tag correct as pulsar image. so it fails `docker/publish.sh` *Modifications* Tag no-repo for both latest and the release version for both pulsar-all and pulsar-standalone *Verify this change* After patching this change, `docker/publish.sh` works as expected.
jiazhai
pushed a commit
that referenced
this pull request
Aug 28, 2019
…andalone images (#4705) *Motivation* pulsar-all and pulsar-standalone dont tag correct as pulsar image. so it fails `docker/publish.sh` *Modifications* Tag no-repo for both latest and the release version for both pulsar-all and pulsar-standalone *Verify this change* After patching this change, `docker/publish.sh` works as expected. (cherry picked from commit d2164eb)
|
@sijie @merlimat @codelipenghui May I ask how "tag no-repo" works here? When @lhotari added the lightweight test image (b472978), there's no such trick and it seems to work fine. Our published images are with repo prefix also. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar-all and pulsar-standalone dont tag correct as pulsar image.
so it fails
docker/publish.shModifications
Tag no-repo for both latest and the release version for both pulsar-all and pulsar-standalone
Verify this change
After patching this change,
docker/publish.shworks as expected.