Allow to create partitioned topic with 1 partition #4764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run integration tests |
|
@jiazhai I think this is a behavior change. Can you just write a PIP for recording this change? |
I think it should be fine as it shouldn't break any existing behavior. Eg.: before you could only create partitioned topics with 2+ partitions, now it will work with 1+ |
fine with me. // run integration tests |
sijie
approved these changes
Jul 21, 2019
easyfan
pushed a commit
to easyfan/pulsar
that referenced
this pull request
Jul 26, 2019
**Motivation** when create partitioned topic, there is a check that `numPartitions > 1`, if numPartitions==1, it will fail. Some user may want to create partitioned topic with only 1 topic at the start time, and during using it, could update to more topics later. **Modification** change check of `numPartitions > 1` to `numPartitions > 0` expect all existing ut passed.
jiazhai
added a commit
that referenced
this pull request
Aug 6, 2019
Motivation In PR #4764, we allow to create partitioned topic with 1 partition, But in Pulsar Client, user still not able to do it. This fix try to make sure user could create consumer/producer for 1 partitioned topic . Modifications - old and new added unit test passed.
This was referenced Aug 9, 2019
jiazhai
added a commit
that referenced
this pull request
Aug 28, 2019
**Motivation** when create partitioned topic, there is a check that `numPartitions > 1`, if numPartitions==1, it will fail. Some user may want to create partitioned topic with only 1 topic at the start time, and during using it, could update to more topics later. **Modification** change check of `numPartitions > 1` to `numPartitions > 0` expect all existing ut passed. (cherry picked from commit 5162393)
jiazhai
added a commit
that referenced
this pull request
Aug 28, 2019
Motivation In PR #4764, we allow to create partitioned topic with 1 partition, But in Pulsar Client, user still not able to do it. This fix try to make sure user could create consumer/producer for 1 partitioned topic . Modifications - old and new added unit test passed. (cherry picked from commit 128287e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
when create partitioned topic, there is a check that
numPartitions > 1, if numPartitions==1, it will fail.Some user may want to create partitioned topic with only 1 topic at the start time, and during using it, could update to more topics later.
Modification
change check of
numPartitions > 1tonumPartitions > 0expect all existing ut passed.