[Issue #4756][broker] Process requests asynchronously on some REST APIs (1) #4765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massakam
added
the
type/enhancement
sijie
approved these changes
Jul 19, 2019
1 task
sijie
pushed a commit
that referenced
this pull request
Jul 23, 2019
Master Issue: #4756 ### Motivation This is a continuation of #4765. ### Modifications Added async rest handlers to the following APIs: ``` DELETE /admin/namespaces/{tenant}/{cluster}/{namespace} PUT /admin/namespaces/{tenant}/{cluster}/{namespace}/unload POST /admin/namespaces/{tenant}/{cluster}/{namespace}/clearBacklog POST /admin/namespaces/{tenant}/{cluster}/{namespace}/clearBacklog/{subscription} POST /admin/namespaces/{tenant}/{cluster}/{namespace}/unsubscribe/{subscription} DELETE /admin/v2/namespaces/{tenant}/{namespace} PUT /admin/v2/namespaces/{tenant}/{namespace}/unload POST /admin/v2/namespaces/{tenant}/{namespace}/clearBacklog POST /admin/v2/namespaces/{tenant}/{namespace}/clearBacklog/{subscription} POST /admin/v2/namespaces/{tenant}/{namespace}/unsubscribe/{subscription} ```
easyfan
pushed a commit
to easyfan/pulsar
that referenced
this pull request
Jul 26, 2019
easyfan
pushed a commit
to easyfan/pulsar
that referenced
this pull request
Jul 26, 2019
Master Issue: apache#4756 ### Motivation This is a continuation of apache#4765. ### Modifications Added async rest handlers to the following APIs: ``` DELETE /admin/namespaces/{tenant}/{cluster}/{namespace} PUT /admin/namespaces/{tenant}/{cluster}/{namespace}/unload POST /admin/namespaces/{tenant}/{cluster}/{namespace}/clearBacklog POST /admin/namespaces/{tenant}/{cluster}/{namespace}/clearBacklog/{subscription} POST /admin/namespaces/{tenant}/{cluster}/{namespace}/unsubscribe/{subscription} DELETE /admin/v2/namespaces/{tenant}/{namespace} PUT /admin/v2/namespaces/{tenant}/{namespace}/unload POST /admin/v2/namespaces/{tenant}/{namespace}/clearBacklog POST /admin/v2/namespaces/{tenant}/{namespace}/clearBacklog/{subscription} POST /admin/v2/namespaces/{tenant}/{namespace}/unsubscribe/{subscription} ```
wolfstudy
pushed a commit
that referenced
this pull request
Nov 20, 2019
(cherry picked from commit 849b6c5)
wolfstudy
pushed a commit
that referenced
this pull request
Nov 20, 2019
Master Issue: #4756 ### Motivation This is a continuation of #4765. ### Modifications Added async rest handlers to the following APIs: ``` DELETE /admin/namespaces/{tenant}/{cluster}/{namespace} PUT /admin/namespaces/{tenant}/{cluster}/{namespace}/unload POST /admin/namespaces/{tenant}/{cluster}/{namespace}/clearBacklog POST /admin/namespaces/{tenant}/{cluster}/{namespace}/clearBacklog/{subscription} POST /admin/namespaces/{tenant}/{cluster}/{namespace}/unsubscribe/{subscription} DELETE /admin/v2/namespaces/{tenant}/{namespace} PUT /admin/v2/namespaces/{tenant}/{namespace}/unload POST /admin/v2/namespaces/{tenant}/{namespace}/clearBacklog POST /admin/v2/namespaces/{tenant}/{namespace}/clearBacklog/{subscription} POST /admin/v2/namespaces/{tenant}/{namespace}/unsubscribe/{subscription} ``` (cherry picked from commit 2cc34af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #4756
Motivation
Some of the REST APIs provided by broker send HTTP request to oneself internally using a PulsarAdmin instance when they receive requests from clients. This may cause a deadlock, as the pulsar-web thread is blocked until a response from oneself is returned. As with #4487, these APIs should be introduced async rest handlers.
Modifications
In this pull-request, added async rest handlers to the following tow APIs for non-persistent topics.
I intend to fix other APIs in subsequent pull-requests.
Verifying this change