Add support of pulsar-kafka-adapter for kafka-0.8 api #4797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean up pulsar-kafka adapter add tests add low level consumer add simple consumer corrected pulsar-client-kafka_0_8 fix the module name add batch and partitioned-topic support fix headers add getOffset api support added pulsarOffset request/response clean up
vzhikserg
reviewed
Jul 24, 2019
...lsar-client-kafka_0_8/src/main/java/org/apache/kafka/clients/consumer/ConsumerConnector.java
Outdated
Show resolved
Hide resolved
..._0_8/src/main/java/org/apache/kafka/clients/simple/consumer/PulsarTopicMetadataResponse.java
Outdated
Show resolved
Hide resolved
..._0_8/src/main/java/org/apache/kafka/clients/simple/consumer/PulsarTopicMetadataResponse.java
Outdated
Show resolved
Hide resolved
...a_0_8/src/test/java/org/apache/pulsar/client/kafka/test/KafkaProducerSimpleConsumerTest.java
Outdated
Show resolved
Hide resolved
sijie
reviewed
Jul 26, 2019
|
@sijie |
|
@rdhabalia thanks |
|
thank you @vzhikserg for your review. I have addressed all the comments and @sijie added integration-test module along with tests as well. |
|
rerun cpp tests |
1 similar comment
|
rerun cpp tests |
sijie
approved these changes
Aug 5, 2019
|
run cpp tests |
|
rerun cpp tests |
|
run java8 tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pulsar already supports pulsar-kafka adapter for kafka api with version > 0.9. However, there are users who use legacy-kafka version in their system with large scale and willing to move to pulsar. This PR provides pulsar-kafka adapter for kafka-api-version 0.8.X. So, this adapter can help users in their migration process from kafka-0.8 to pulsar.