[Transaction][buffer] Add data ledger position in txn commit marker #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- *Motivation* Add the data ledger position into the commit marker of the transaction log. *Modifications* Create a new TxnCommitMarker in the proto.
|
run integration tests |
sijie
requested changes
Jul 27, 2019
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Markers.java
Show resolved
Hide resolved
|
run java8 tests |
1 similar comment
|
run java8 tests |
sijie
approved these changes
Jul 29, 2019
| try { | ||
| builder = PulsarMarkers.TxnCommitMarker.newBuilder(); | ||
| return builder.mergeFrom(inStream, null).build(); | ||
| }finally { |
There was a problem hiding this comment.
Suggested change
| }finally { | |
| } finally { |
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Markers.java
Outdated
Show resolved
Hide resolved
|
run cpp tests |
|
Change the Milestone to 2.4.2, because of conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add the data ledger position into the commit marker of the transaction log.
Modifications
Create a new TxnCommitMarker in the proto.