-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[schema] Improve SchemaInfoProvider to fetch schema info asynchronously #4836
Conversation
*Motivation* Currently fetching schema information is done synchronously. It is called in netty callback threads and will potentially block async operations. *Modifications* Make most of the operations asynchronously in SchemaInfoProvider.
/cc @congbobo184 can you please also review this? |
run cpp tests |
*Motivation* Currently KeyValue schema doesn't support using AUTO_CONSUME. This PR is to add this support. This PR is based on apache#4836 *Changes* - refactor a bit on Schema interface to support fetching schema info for both AutoConsumeSchema and KeyValueSchema before subscribing - add AUTO_CONSUME support to KeyValueSchema - add tests
run cpp tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me.
run cpp tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. great improvement.
…ema (#4839) *Motivation* Currently KeyValue schema doesn't support using AUTO_CONSUME. This PR is to add this support. This PR is based on #4836 *Changes* - refactor a bit on Schema interface to support fetching schema info for both AutoConsumeSchema and KeyValueSchema before subscribing - add AUTO_CONSUME support to KeyValueSchema - add tests
*Motivation* Currently fetching schema information is done synchronously. It is called in netty callback threads and will potentially block async operations. *Modifications* Make most of the operations asynchronously in SchemaInfoProvider. (cherry picked from commit 91c4254)
…ema (#4839) *Motivation* Currently KeyValue schema doesn't support using AUTO_CONSUME. This PR is to add this support. This PR is based on #4836 *Changes* - refactor a bit on Schema interface to support fetching schema info for both AutoConsumeSchema and KeyValueSchema before subscribing - add AUTO_CONSUME support to KeyValueSchema - add tests (cherry picked from commit dd7cc89)
Motivation
Currently fetching schema information is done synchronously.
It is called in netty callback threads and will potentially block
async operations.
Modifications
Make most of the operations asynchronously in SchemaInfoProvider.