Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch throwable in interceptors of consumer and producer. #4860

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Catch throwable in interceptors of consumer and producer. #4860

merged 1 commit into from
Aug 1, 2019

Conversation

codelipenghui
Copy link
Contributor

Motivation

Catch throwable in interceptors of consumer and producer.

Verifying this change

Add new unit test.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: ( no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui
Copy link
Contributor Author

@lovelle please help review this PR.

@codelipenghui
Copy link
Contributor Author

run cpp tests
run integration Tests

@codelipenghui
Copy link
Contributor Author

run integration Tests

@codelipenghui
Copy link
Contributor Author

run integration Tests

@codelipenghui codelipenghui added this to the 2.4.1 milestone Aug 1, 2019
@codelipenghui codelipenghui self-assigned this Aug 1, 2019
@codelipenghui codelipenghui merged commit 00ce781 into apache:master Aug 1, 2019
jiazhai pushed a commit that referenced this pull request Aug 28, 2019
@codelipenghui @jiazhai
Catch throwable in interceptors of consumer and producer. (#4860)
ae3494d 
(cherry picked from commit 00ce781)
@codelipenghui codelipenghui deleted the handle_error_in_interceptors branch May 19, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@jiazhai jiazhai Awaiting requested review from jiazhai

Assignees

@codelipenghui codelipenghui

Labels
area/client
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codelipenghui @sijie