[Transaction][buffer] Add new commands for the transaction #4866
Conversation
--- *Motivation* Add new commands for the transaction. *Modifications* - Add new property for `CommandSend` - Add new command `CommandEndTxnOnPartition`
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
Outdated
Show resolved
Hide resolved
|
@sijie updated. |
|
run cpp tests |
|
// Couldn?t find any executable in /home/jenkins/tools/maven/apache-maven-3.5.0 run integration tests |
|
@sijie I add more commands in the pull request. PTAL. Thanks. |
|
run cpp tests |
| @@ -23,42 +23,42 @@ option java_package = "org.apache.pulsar.common.api.proto"; | |||
| option optimize_for = LITE_RUNTIME; | |||
|
|
|||
| message Schema { | |||
| enum Type { | |||
There was a problem hiding this comment.
Seems most of the changes in this file is the code alignment change. I would suggest keep the original format, so it would be easy to find what is really changed for this PR.
There was a problem hiding this comment.
Sorry for the inconvenience to your review. All I added commands are under the comments called the transaction related.
I updated the alignments because there are two types of alignments in this file. I replace all the tab with 4 spaces. And I think it is easier to keep consistent when we update this file in the future.
There was a problem hiding this comment.
OK. It is better to do the alignments in a separate PR.
There was a problem hiding this comment.
Thanks for your reminder. I will pay more attention next time.
| optional uint64 txnid_least_bits = 2 [default = 0]; | ||
| optional uint64 txnid_most_bits = 3 [default = 0]; | ||
| optional ServerError error = 4; | ||
| optional string message = 5; |
There was a problem hiding this comment.
What message will return for all these Response above?
There was a problem hiding this comment.
Ok. Seems there is also other command response with message returned and use in log.
Motivation
Add new commands for the transaction.
Modifications
CommandSendCommandEndTxnOnPartition