[Transaction] Introduce Transaction Client API #4952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* Introduce the transaction API to setup the skeleton on implementing the transactional client. Also add an example to show how to use the transaction API. *Modifications* - Add TransactionBuilder and Transaction - Add `newTransaction` to client - Add `newMessage(Transaction)` method to producer - Add `acknowledgeAsyc(MessageId, Transaction)` method to consumer NOTE: these methods are only exposed to the implementation classes (ProducerImpl, ProducerImpl, and ConsumerImpl). Will only add them to the interfaces when the features are completed.
|
run java8 tests |
1 similar comment
|
run java8 tests |
|
run integration tests |
|
run cpp tests |
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Introduce the transaction API to setup the skeleton on implementing
the transactional client.
Also add an example to show how to use the transaction API.
Modifications
newTransactionto clientnewMessage(Transaction)method to produceracknowledgeAsyc(MessageId, Transaction)method to consumerNOTE: these methods are only exposed to the implementation classes (ProducerImpl, ProducerImpl, and ConsumerImpl).
Will only add them to the interfaces when the features are completed.