Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 4969] fix fd leakage in FunctionActioner.downloadFile #4970

Merged
merged 1 commit into from
Aug 18, 2019
Merged

[Issue 4969] fix fd leakage in FunctionActioner.downloadFile #4970

merged 1 commit into from
Aug 18, 2019

Conversation

freeznet
Copy link
Contributor

Fixes #4969

Motivation

close FileOutputStream after WorkerUtils.downloadFromBookkeeper

@sijie sijie added area/function type/bug The PR fixed a bug or issue reported a bug labels Aug 18, 2019
@sijie sijie added this to the 2.4.1 milestone Aug 18, 2019
@sijie sijie merged commit 2c21500 into apache:master Aug 18, 2019
jiazhai pushed a commit that referenced this pull request Aug 28, 2019
@freeznet @jiazhai
prevent fd leakage when WorkerUtils.downloadFromBookkeeper (#4970)
5a5533f 
Fixes #4969

### Motivation

close `FileOutputStream` after `WorkerUtils.downloadFromBookkeeper`
(cherry picked from commit 2c21500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@wolfstudy wolfstudy Awaiting requested review from wolfstudy

Assignees

@freeznet freeznet

Labels
area/function type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

FD leakage found in FunctionActioner.downloadFile
2 participants
@freeznet @sijie