Fix the getSchema logic in pulsar proxy #4975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* The getSchema logic in Pulsar proxy handler doesn't handle the case that the request doesn't have schema version. *Modification* - Fix the logic to handle the case that a GetSchema request doesn't have schema version. - Forward the GetSchemaResponse back to the client *Tests* The GetSchema tests in ProxyTest was disabled by mistake. Turn it on.
sijie
added
type/bug
codelipenghui
approved these changes
Aug 19, 2019
|
@congbobo184 Please help take a look these changes, thanks. |
|
overall looks good to me. :) |
congbobo184
approved these changes
Aug 19, 2019
jiazhai
pushed a commit
that referenced
this pull request
Aug 28, 2019
*Motivation* The getSchema logic in Pulsar proxy handler doesn't handle the case that the request doesn't have schema version. *Modification* - Fix the logic to handle the case that a GetSchema request doesn't have schema version. - Forward the GetSchemaResponse back to the client *Tests* The GetSchema tests in ProxyTest was disabled by mistake. Turn it on. (cherry picked from commit 676fd71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The getSchema logic in Pulsar proxy handler doesn't handle the case that
the request doesn't have schema version.
Modification
Tests
The GetSchema tests in ProxyTest was disabled by mistake. Turn it on.