[pulsar-broker] add broker-bookie mTLS support #5042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Aug 26, 2019
conf/broker.conf
Outdated
| @@ -457,6 +457,34 @@ bookkeeperClientMinAvailableBookiesInIsolationGroups= | |||
| # Disable Sticy Read until {@link https://github.com/apache/bookkeeper/issues/1970} is fixed | |||
| bookkeeperEnableStickyReads=false | |||
|
|
|||
| # Set the client security provider factory class name. | |||
| # Default: org.apache.bookkeeper.tls.TLSContextFactory | |||
| bookkeeperTLSProviderFactoryClass= | |||
There was a problem hiding this comment.
Should we set this to its default value?
conf/broker.conf
Outdated
| bookkeeperTLSProviderFactoryClass= | ||
|
|
||
| # Enable tls authentication with bookie | ||
| bookkeeperTLSClientAuthentication= |
There was a problem hiding this comment.
Suggested change
| bookkeeperTLSClientAuthentication= | |
| bookkeeperTLSClientAuthentication=false |
conf/standalone.conf
Outdated
| bookkeeperTLSProviderFactoryClass= | ||
|
|
||
| # Enable tls authentication with bookie | ||
| bookkeeperTLSClientAuthentication= |
There was a problem hiding this comment.
Suggested change
| bookkeeperTLSClientAuthentication= | |
| bookkeeperTLSClientAuthentication=false |
conf/standalone.conf
Outdated
| @@ -280,6 +280,35 @@ bookkeeperClientSecondaryIsolationGroups= | |||
| # else broker will include bookkeeperClientSecondaryIsolationGroups bookies in isolated list. | |||
| bookkeeperClientMinAvailableBookiesInIsolationGroups= | |||
|
|
|||
| # Set the client security provider factory class name. | |||
| # Default: org.apache.bookkeeper.tls.TLSContextFactory | |||
| bookkeeperTLSProviderFactoryClass= | |||
There was a problem hiding this comment.
Suggested change
| bookkeeperTLSProviderFactoryClass= | |
| bookkeeperTLSProviderFactoryClass=org.apache.bookkeeper.tls.TLSContextFactory |
merlimat
approved these changes
Aug 26, 2019
|
rerun java8 tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR will help to enable mTLS between broker and bookie. Broker can configure tls configuration to connect with bookie.