[bookkeeper] Don't return DEFAULT_RACK if ZkBookieRackAffinityMapping can't resolve network location #5067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can't resolve network location *Motivation* Different placement policy has different default rack information. For example, the default rack for `RackAware` is `/default-rack` and the default rack for `RegionAware` is `/default-region/default-rack`. If we return the wrong default rack, it can potentially cause inconsistent network locations inserted to the network topology and causing the following errors. ``` 15:36:30.083 [BookKeeperClientScheduler-OrderedScheduler-0-0] ERROR org.apache.bookkeeper.net.NetworkTopologyImpl - Error: can't add leaf node <Bookie:1.1.1.2:3181> at depth 2 to topology: Number of racks: 1 Expected number of leaves:1 /sh/rack1/1.1.1.1:3181 15:36:30.083 [BookKeeperClientScheduler-OrderedScheduler-0-0] ERROR org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl - Unexpected exception while handling joining bookie 1.1.1.2:3181 org.apache.bookkeeper.net.NetworkTopologyImpl$InvalidTopologyException: Invalid network topology. You cannot have a rack and a non-rack node at the same level of the network topology. ```
sijie
added
type/bug
merlimat
approved these changes
Aug 29, 2019
|
run cpp tests |
|
run java8 tests |
wolfstudy
pushed a commit
that referenced
this pull request
Nov 20, 2019
… can't resolve network location (#5067) *Motivation* Different placement policy has different default rack information. For example, the default rack for `RackAware` is `/default-rack` and the default rack for `RegionAware` is `/default-region/default-rack`. If we return the wrong default rack, it can potentially cause inconsistent network locations inserted to the network topology and causing the following errors. ``` 15:36:30.083 [BookKeeperClientScheduler-OrderedScheduler-0-0] ERROR org.apache.bookkeeper.net.NetworkTopologyImpl - Error: can't add leaf node <Bookie:1.1.1.2:3181> at depth 2 to topology: Number of racks: 1 Expected number of leaves:1 /sh/rack1/1.1.1.1:3181 15:36:30.083 [BookKeeperClientScheduler-OrderedScheduler-0-0] ERROR org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl - Unexpected exception while handling joining bookie 1.1.1.2:3181 org.apache.bookkeeper.net.NetworkTopologyImpl$InvalidTopologyException: Invalid network topology. You cannot have a rack and a non-rack node at the same level of the network topology. ``` (cherry picked from commit c993375)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Different placement policy has different default rack information. For example, the default rack for
RackAwareis
/default-rackand the default rack forRegionAwareis/default-region/default-rack. If we return thewrong default rack, it can potentially cause inconsistent network locations inserted to the network topology and
causing the following errors.