Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storage size always 0 without subscription. #5108

Merged
merged 3 commits into from Sep 5, 2019
Merged

Fix storage size always 0 without subscription. #5108

merged 3 commits into from Sep 5, 2019

Conversation

codelipenghui
Copy link
Contributor

Motivation

Fixes issue-182

@codelipenghui
Copy link
Contributor Author

@tuteng please help review this change.

@codelipenghui codelipenghui self-assigned this Sep 4, 2019
@codelipenghui codelipenghui added this to the 2.4.2 milestone Sep 4, 2019
@sijie sijie added area/admin type/bug The PR fixed a bug or issue reported a bug labels Sep 4, 2019
@tuteng
Copy link
Member

tuteng commented Sep 4, 2019

LGTM

@sijie
Copy link
Member

sijie commented Sep 4, 2019

retest this please

@codelipenghui
Copy link
Contributor Author

run cpp tests
run java8 tests

@codelipenghui
Copy link
Contributor Author

run cpp tests

@codelipenghui
Copy link
Contributor Author

run Integration Tests

@codelipenghui
Copy link
Contributor Author

run cpp tests
run Integration Tests

@codelipenghui
Copy link
Contributor Author

run cpp tests

@sijie sijie merged commit 5fa40cb into apache:master Sep 5, 2019
wolfstudy pushed a commit that referenced this pull request Nov 20, 2019
@codelipenghui @wolfstudy
Fix storage size always 0 without subscription. (#5108)
3e8b33c 
### Motivation

Fixes [issue-182](streamnative/pulsar-manager#182)

(cherry picked from commit 5fa40cb)
@jiazhai jiazhai mentioned this pull request Nov 25, 2019
Closed
@Anonymitaet Anonymitaet mentioned this pull request Dec 5, 2019
Merged
@k2la k2la mentioned this pull request Dec 23, 2019
Merged
@codelipenghui codelipenghui deleted the storage_size_0_without_subscription branch May 19, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@jiazhai jiazhai jiazhai approved these changes

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@codelipenghui codelipenghui

Labels
area/admin type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

Storage size is always 0 Bytes
4 participants
@codelipenghui @tuteng @sijie @jiazhai