Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client keepalive interval configurable on pulsar-client-kafka #5131

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

masnnuller
Copy link
Contributor

Motivation

Make client keepalive interval configurable on pulsar-client-kafka.

Modifications

Add pulsar.keepalive.interval.ms config property to PulsarClientConfig

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@sijie sijie added component/kafka type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Sep 6, 2019
@sijie sijie added this to the 2.5.0 milestone Sep 6, 2019
@sijie
Copy link
Member

sijie commented Sep 6, 2019

run java8 tests

@merlimat merlimat merged commit 0f40adc into apache:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants