Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pulsar-broker] Make some member variables of Dispatcher volatile #5193

Merged
merged 1 commit into from
Sep 17, 2019
Merged

[pulsar-broker] Make some member variables of Dispatcher volatile #5193

merged 1 commit into from
Sep 17, 2019

Conversation

massakam
Copy link
Contributor

Some of the variables of the Dispatcher classes seem to should be volatile, so I fixed them. For example, the variable havePendingRead is corrently volatile in PersistentDispatcherSingleActiveConsumer but not in PersistentDispatcherMultipleConsumers.

@massakam massakam added this to the 2.4.2 milestone Sep 14, 2019
@massakam massakam self-assigned this Sep 14, 2019
@massakam
Copy link
Contributor Author

rerun java8 tests

2 similar comments
@massakam
Copy link
Contributor Author

rerun java8 tests

@massakam
Copy link
Contributor Author

rerun java8 tests

@nkurihar nkurihar merged commit b9e7bf3 into apache:master Sep 17, 2019
@massakam massakam deleted the volatile branch September 17, 2019 02:05
wolfstudy pushed a commit that referenced this pull request Nov 20, 2019
@wolfstudy
Make some member variables of Dispatcher volatile (#5193)
90ec8e1 
(cherry picked from commit b9e7bf3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@jiazhai jiazhai jiazhai approved these changes

@nkurihar nkurihar nkurihar approved these changes

Assignees

@massakam massakam

Labels
area/broker
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@massakam @sijie @jiazhai @nkurihar