Bug in Message Deduplication that may cause incorrect client/broker interaction #5243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun java8 tests |
|
run integration tests |
|
rerun integration tests |
sijie
approved these changes
Sep 22, 2019
|
rerun integration tests |
2 similar comments
|
rerun integration tests |
|
rerun integration tests |
|
run integration tests |
jiazhai
approved these changes
Sep 24, 2019
|
run integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Partially fixes #5218
Will be making subsequent PRs to fix issues with handling BK write failures
Modifications
The fix is two-fold:
Double check the pending messages and return error to producer when the dup status is uncertain (eg. message is still pending)
Sync back the lastPushed map with the lastStored map after the failures