Fix client backoff #5261
Merged
Fix client backoff #5261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Sep 23, 2019
|
rerun integration tests |
|
run integration tests |
1 similar comment
|
run integration tests |
|
rerun integration tests |
wolfstudy
pushed a commit
that referenced
this pull request
Nov 20, 2019
* fix client backoff * fix tests * cleaning up (cherry picked from commit ee42cf4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The #3848 allowed users to be able to configure initial backoff delay and max backoff delay. However, the PR doesn't actually properly propagate those user settings and defaults are used regardless of whether the user configured those settings in the pulsar client