fix behavior when getting a key from functions state that doesn't exist #5272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrypeng
added
type/bug
|
@addisonj please take a look |
merlimat
approved these changes
Sep 25, 2019
|
lgtm, thanks for responding to this do quickly! |
jiazhai
approved these changes
Sep 25, 2019
|
run integration test |
|
run integration tests |
|
rerun integration tests |
3 similar comments
|
rerun integration tests |
|
rerun integration tests |
|
rerun integration tests |
addisonj
pushed a commit
to instructure/pulsar
that referenced
this pull request
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when a user attempts to fetch from function state a key that doesn't exist, an NPE will happen.
Modifications
Add the correct error handling for keys that don't exist.