Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add *MongoDB sink connector guide* #5289

Merged
merged 2 commits into from Oct 2, 2019
Merged

[Doc] Add *MongoDB sink connector guide* #5289

merged 2 commits into from Oct 2, 2019

Conversation

Anonymitaet
Copy link
Member

Fix #5015

@Anonymitaet
Copy link
Member Author

@tuteng could you please help review? Thank you

@Anonymitaet Anonymitaet mentioned this pull request Sep 29, 2019
Closed
tuteng
tuteng reviewed Sep 30, 2019
View reviewed changes
site2/docs/io-mongo-sink.md
"batchSize": "2",
"batchTimeMs": "500"
}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is best to add a port number to mongo's link address, as shown below:

"mongoUri": "mongodb://localhost:27017",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've updated

site2/docs/io-mongo-sink.md Outdated
| `database` | String| true| " " (empty string)| The database name to which the collection belongs. |
| `collection` | String| true| " " (empty string)| The collection name to which the connector writes messages. |
| `batchSize` | int|false|DEFAULT_BATCH_SIZE | The batch size of writing messages to collections. |
| `batchTimeMs` |long|false|DEFAULT_BATCH_TIME_MS| The batch operation interval in milliseconds. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 100 instead of DEFAULT_BATCH_SIZE looks clearer
Using 1000 instead of DEFAULT_BATCH_TIME_MS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've updated

@merlimat merlimat added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 30, 2019
@sijie sijie added this to the 2.5.0 milestone Oct 2, 2019
@sijie sijie merged commit 2ed17a6 into apache:master Oct 2, 2019
@Anonymitaet Anonymitaet deleted the mg-sink branch October 12, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@tuteng tuteng tuteng approved these changes

Assignees

@Anonymitaet Anonymitaet

Labels
area/connector doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

[Doc] Update Pulsar Connector Guide
4 participants
@Anonymitaet @sijie @tuteng @merlimat