Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify delivery delay in C++ client #5317

Merged
merged 5 commits into from Oct 28, 2019
Merged

Allow to specify delivery delay in C++ client #5317

merged 5 commits into from Oct 28, 2019

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Oct 4, 2019

Motivation

Allow to specify delivery delay in C++ and C client.

@merlimat merlimat added the type/feature The PR added a new feature or issue requested a new feature label Oct 4, 2019
@merlimat merlimat added this to the 2.4.2 milestone Oct 4, 2019
@merlimat merlimat self-assigned this Oct 4, 2019
@merlimat
Copy link
Contributor Author

merlimat commented Oct 7, 2019

run java8 tests
run integration tests

1 similar comment
@merlimat
Copy link
Contributor Author

merlimat commented Oct 7, 2019

run java8 tests
run integration tests

@codelipenghui
Copy link
Contributor

run java8 tests

@merlimat
Copy link
Contributor Author

run java8 tests

@codelipenghui
Copy link
Contributor

retest this please

@codelipenghui
Copy link
Contributor

run cpp tests

@everactivetim
Copy link

What is needed to move this along? I've personally tested the changes via my modifications to the Go client to support this. I would love to see it landed ASAP. We want to replace some custom logic that we had to write because this was not yet supported in the Go client.

@merlimat
Copy link
Contributor Author

The ASF Jenkins CI is pretty messed up at the moment. We're working on getting that fixed so that we get through the backlog of PRs.

@merlimat
Copy link
Contributor Author

run cpp tests
run integration tests

1 similar comment
@wolfstudy
Copy link
Member

run cpp tests
run integration tests

@merlimat merlimat merged commit 0984f42 into apache:master Oct 28, 2019
@merlimat merlimat deleted the delayed-messages-c++ branch October 28, 2019 21:04
wolfstudy pushed a commit that referenced this pull request Nov 20, 2019
@merlimat @wolfstudy
Allow to specify delivery delay in C++ client (#5317)
c89fb48 
* Allow to specify delivery delay in C++ client

* Fixed symbols visibility to make it available for unit tests

* Fixed format

(cherry picked from commit 0984f42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@ivankelly ivankelly Awaiting requested review from ivankelly

@sijie sijie Awaiting requested review from sijie

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@massakam massakam Awaiting requested review from massakam

Assignees

@merlimat merlimat

Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@merlimat @codelipenghui @everactivetim @wolfstudy @sijie