Not allow use acknowledgeCumulative on Key_shared subscription. #5339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run integration tests |
merlimat
reviewed
Oct 8, 2019
| Message<Integer> message = consumer.receive(); | ||
| if (i == 9) { | ||
| try { | ||
| consumer.acknowledgeCumulative(message); |
There was a problem hiding this comment.
add fail("should have failed") after calling ack, to verify the call is indeed throwing exception
| if (i == 9) { | ||
| try { | ||
| consumer.acknowledgeCumulative(message); | ||
| } catch (PulsarClientException e) { |
There was a problem hiding this comment.
This could be simplified into } catch (PulsarClientException.InvalidConfigurationException e) {
|
run Integration Tests |
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Jan 17, 2020
…he#5339) * Not allow use acknowledgeCumulative on Key_shared subscription. * fix comments * C++ Client add acknowledgeCumulative not allowed check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Key_Shared subscription is a enhancement of shared subscription, we should avoid use acknowledgeCumulative on Key_shared subscription
Modifications
Add allow acknowledgeCumulative check for Key_shared subscription
Verifying this change
Add new unit test.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation