Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[functions][Issue:5350]Fix pulsar can't load the customized SerDe #5357

Merged
merged 6 commits into from
Oct 28, 2019
Merged

[functions][Issue:5350]Fix pulsar can't load the customized SerDe #5357

merged 6 commits into from
Oct 28, 2019

Conversation

wolfstudy
Copy link
Member

@wolfstudy wolfstudy commented Oct 10, 2019 •
edited
Loading

Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #5350

Motivation

When using the --output-serde-classname option, functionClassLoader is not set correctly.

@wolfstudy
[functions][Issue:5350]Fix pulsar can't load the customized SerDe
412d077 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy wolfstudy self-assigned this Oct 10, 2019
@wolfstudy
Copy link
Member Author

@sijie @jerrypeng PTAL

@wolfstudy
Copy link
Member Author

ping @sijie @jerrypeng PTAL thanks

@wolfstudy
Copy link
Member Author

run cpp tests

@wolfstudy
Copy link
Member Author

@sijie PTAL

@wolfstudy
fix comments
7059843 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
Copy link
Member Author

@sijie PTAL again, thanks.

@wolfstudy
Copy link
Member Author

run java8 tests

@wolfstudy wolfstudy added this to the 2.4.2 milestone Oct 28, 2019
@sijie sijie merged commit 18712eb into apache:master Oct 28, 2019
wolfstudy added a commit that referenced this pull request Nov 20, 2019
@wolfstudy
[functions][Issue:5350]Fix pulsar can't load the customized SerDe (#5357
10a4501 
)

Fixes #5350

### Motivation

When using the `--output-serde-classname` option, `functionClassLoader` is not set correctly.

(cherry picked from commit 18712eb)
@tisonkun tisonkun mentioned this pull request Apr 19, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

Assignees

@wolfstudy wolfstudy

Labels
area/function
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

Pulsar can't load the customized SerDe
2 participants
@wolfstudy @sijie