Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[functions][Issue:5350]Fix pulsar can't load the customized SerDe #5357

Merged
merged 6 commits into from Oct 28, 2019

Conversation

@wolfstudy
Copy link
Member

wolfstudy commented Oct 10, 2019

Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #5350

Motivation

When using the --output-serde-classname option, functionClassLoader is not set correctly.

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy wolfstudy self-assigned this Oct 10, 2019
@wolfstudy wolfstudy requested review from jerrypeng and sijie Oct 10, 2019
@wolfstudy

This comment has been minimized.

Copy link
Member Author

wolfstudy commented Oct 10, 2019

@wolfstudy

This comment has been minimized.

Copy link
Member Author

wolfstudy commented Oct 12, 2019

ping @sijie @jerrypeng PTAL thanks

wolfstudy added 2 commits Oct 12, 2019
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
wolfstudy added 2 commits Oct 25, 2019
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy

This comment has been minimized.

Copy link
Member Author

wolfstudy commented Oct 26, 2019

run cpp tests

@wolfstudy

This comment has been minimized.

Copy link
Member Author

wolfstudy commented Oct 26, 2019

@sijie PTAL

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy

This comment has been minimized.

Copy link
Member Author

wolfstudy commented Oct 28, 2019

@sijie PTAL again, thanks.

@wolfstudy

This comment has been minimized.

Copy link
Member Author

wolfstudy commented Oct 28, 2019

run java8 tests

@wolfstudy wolfstudy added this to the 2.4.2 milestone Oct 28, 2019
@sijie
sijie approved these changes Oct 28, 2019
@sijie sijie merged commit 18712eb into apache:master Oct 28, 2019
3 checks passed
3 checks passed
Jenkins: C++ / Python Tests SUCCESS
Details
Jenkins: Integration Tests SUCCESS
Details
Jenkins: Java 8 - Unit Tests SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.