Skip to content

PIP-45: Switch ManagedLedger to use MetadataStore interface #5358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 12, 2020
Merged

PIP-45: Switch ManagedLedger to use MetadataStore interface #5358

merged 8 commits into from
Feb 12, 2020

Conversation

@merlimat
Copy link
Contributor

@merlimat merlimat commented Oct 10, 2019

Motivation

Converted Managed Ledger to use the MetadataStore interface.

Note: this doesn't yet address the instantiation of MetadataStore, rather just creates a ZKMetadataStore instance. The instantiation plumbing will be completed once all the other parts are already in place.

@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Oct 10, 2019
@merlimat merlimat added this to the 2.5.0 milestone Oct 10, 2019
@merlimat merlimat self-assigned this Oct 10, 2019
@merlimat
Copy link
Contributor Author

merlimat commented Oct 11, 2019

run java8 tests
run integration tests

@merlimat
Copy link
Contributor Author

merlimat commented Oct 24, 2019

run java8 tests
run integration tests

@merlimat
Copy link
Contributor Author

merlimat commented Oct 31, 2019

run java8 tests

@sijie
Copy link
Member

sijie commented Nov 6, 2019

retest this please

@sijie
Copy link
Member

sijie commented Nov 6, 2019

run java8 tests

2 similar comments
@sijie
Copy link
Member

sijie commented Nov 7, 2019

run java8 tests

@sijie
Copy link
Member

sijie commented Nov 19, 2019

run java8 tests

@sijie
Copy link
Member

sijie commented Nov 22, 2019

run java8 tests
run cpp tests

@sijie sijie modified the milestones: 2.5.0, 2.6.0 Nov 25, 2019
@merlimat merlimat merged commit 24eccaf into apache:master Feb 12, 2020
@sijie sijie mentioned this pull request May 20, 2020
Closed
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@merlimat @huangdx0726
PIP-45: Switch ManagedLedger to use MetadataStore interface (apache#5358
38879e8 
)

* Switch ManagedLedger to use MetadataStore interface

* Use different thread for ZK callbacks

* Properly close metadata store in ml factory

* Fixed licenses

* Fixed problem in MockZookeeper
@poorbarcode poorbarcode mentioned this pull request May 11, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sijie sijie sijie approved these changes

@rdhabalia rdhabalia rdhabalia approved these changes

@ivankelly ivankelly Awaiting requested review from ivankelly

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@massakam massakam Awaiting requested review from massakam

Assignees

@merlimat merlimat

Labels

type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

2.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@merlimat @sijie @rdhabalia