Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim messages which less than mark delete position for message redelivery #5378

Merged

Conversation

@codelipenghui
Copy link
Contributor

codelipenghui commented Oct 12, 2019

Master Issue: #5377

Motivation

Fix #5377

Modifications

Trim messages which less than mark delete position for message redelivery

Verifying this change

Add new unit test for this change

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 12, 2019

run java8 tests
run integration tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 13, 2019

run integration tests

}
}

private List<PositionImpl> trimByMarkDeletePosition(List<PositionImpl> positions) {

This comment has been minimized.

Copy link
@merlimat

merlimat Oct 14, 2019

Contributor

This is applying this filtering which generates a lot of temp objects each time these redeliveries are done. Why not clear the map when the clear-backlog or seek commands are issued?

This comment has been minimized.

Copy link
@codelipenghui

codelipenghui Oct 14, 2019

Author Contributor

Replace with removeIf(), please take a look.

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 14, 2019

retest this please

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 14, 2019

run java8 tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 14, 2019

run cpp tests

@jiazhai

This comment has been minimized.

Copy link
Contributor

jiazhai commented Oct 14, 2019

run cpp tests

@sijie

This comment has been minimized.

Copy link
Contributor

sijie commented Oct 14, 2019

run cpp tests
run java8 tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 15, 2019

retest this please

1 similar comment
@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 20, 2019

retest this please

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 20, 2019

run cpp tests
run integration tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 20, 2019

run java8 tests
run integration tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 20, 2019

run integration tests

2 similar comments
@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 22, 2019

run integration tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 24, 2019

run integration tests

@sijie
sijie approved these changes Oct 24, 2019
…k_deleted_position
@sijie
sijie approved these changes Oct 24, 2019
@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 24, 2019

run java8 tests

@codelipenghui

This comment has been minimized.

Copy link
Contributor Author

codelipenghui commented Oct 24, 2019

run integration Tests

@wolfstudy

This comment has been minimized.

Copy link
Member

wolfstudy commented Oct 29, 2019

run java8 tests

1 similar comment
@wolfstudy

This comment has been minimized.

Copy link
Member

wolfstudy commented Oct 29, 2019

run java8 tests

@wolfstudy

This comment has been minimized.

Copy link
Member

wolfstudy commented Oct 29, 2019

org.apache.pulsar.broker.service.PeerReplicatorTest.testPeerClusterInReplicationClusterListChange

run java8 tests

@wolfstudy

This comment has been minimized.

Copy link
Member

wolfstudy commented Oct 30, 2019

org.apache.pulsar.client.api.BrokerServiceLookupTest.setup
org.apache.pulsar.client.api.SimpleSchemaTest.setup
org.apache.pulsar.client.api.SubscriptionMessageDispatchThrottlingTest.setup
org.apache.pulsar.client.api.v1.V1_ProducerConsumerTest.setup
org.apache.pulsar.functions.worker.PulsarFunctionE2ESecurityTest.testAuthorizationWithAnonymousUser

run java8 tests

@wolfstudy

This comment has been minimized.

Copy link
Member

wolfstudy commented Oct 30, 2019

run java8 tests

@wolfstudy

This comment has been minimized.

Copy link
Member

wolfstudy commented Oct 30, 2019

org.apache.pulsar.broker.admin.AdminApiOffloadTest.testOffloadV1
org.apache.pulsar.functions.worker.PulsarFunctionE2ESecurityTest.testAuthorizationWithAnonymousUser

run java8 tests

@wolfstudy wolfstudy merged commit b11211f into apache:master Oct 30, 2019
3 checks passed
3 checks passed
Jenkins: C++ / Python Tests SUCCESS
Details
Jenkins: Integration Tests SUCCESS
Details
Jenkins: Java 8 - Unit Tests SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.