Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for partitioned topic consumer seek by time. #5435

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Add support for partitioned topic consumer seek by time. #5435

merged 2 commits into from
Oct 24, 2019

Conversation

codelipenghui
Copy link
Contributor

Motivation

Add support for partitioned topic consumer seek by time.

Modifications

Call each partition consumer seekAsync() while call partitioned consumer seekAsync()

Verifying this change

Update unit tests for consumer.seek().

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui self-assigned this Oct 22, 2019
@codelipenghui codelipenghui added this to the 2.5.0 milestone Oct 22, 2019
@aahmed-se
Copy link
Contributor

run cpp tests

@codelipenghui
Copy link
Contributor Author

run Integration Tests

@aahmed-se
Copy link
Contributor

@sijie @merlimat please review this.

@sijie sijie merged commit a95bea6 into apache:master Oct 24, 2019
@jiazhai jiazhai modified the milestones: 2.5.0, 2.4.2 Nov 1, 2019
wolfstudy pushed a commit that referenced this pull request Nov 20, 2019
@codelipenghui @wolfstudy
Add support for partitioned topic consumer seek by time. (#5435)
6b3c7b7 
Add support for partitioned topic consumer seek by time.

Call each partition consumer seekAsync() while call partitioned consumer seekAsync()

Update unit tests for consumer.seek().

(cherry picked from commit a95bea6)
@codelipenghui codelipenghui deleted the partitioned_consumer_seek_time branch May 19, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@aahmed-se aahmed-se aahmed-se approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@wolfstudy wolfstudy Awaiting requested review from wolfstudy

@jiazhai jiazhai Awaiting requested review from jiazhai

@massakam massakam Awaiting requested review from massakam

Assignees

@codelipenghui codelipenghui

Labels
area/client
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codelipenghui @aahmed-se @sijie @jiazhai