Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pulsar-broker] fix broken custom auth-provider that uses authenticationData #5462

Merged
merged 1 commit into from
Oct 30, 2019
Merged

[pulsar-broker] fix broken custom auth-provider that uses authenticationData #5462

merged 1 commit into from
Oct 30, 2019

Conversation

rdhabalia
Copy link
Contributor

Motivation

with #3677, ServerCnx is not storing client's authenticationData which is used by custom authorization provider and it always receives authenticationData as null and custom auth-provider fails with authorization.

@rdhabalia rdhabalia added this to the 2.4.2 milestone Oct 24, 2019
@rdhabalia rdhabalia self-assigned this Oct 24, 2019
@wolfstudy
Copy link
Member

@sijie @jiazhai PTAL

@wolfstudy
Copy link
Member

run java8 tests

@jiazhai
Copy link
Member

jiazhai commented Oct 28, 2019

@rdhabalia Thanks for this fix.

@wolfstudy
Copy link
Member

org.apache.pulsar.broker.admin.AdminApiOffloadTest.testOffloadV1

run java8 tests

@wolfstudy
Copy link
Member

org.apache.pulsar.functions.worker.PulsarFunctionE2ESecurityTest.testAuthorizationWithAnonymousUser

run java8 tests

@wolfstudy
Copy link
Member

run java8 tests

@wolfstudy
Copy link
Member

run java8 tests

@wolfstudy wolfstudy merged commit ebaf97c into apache:master Oct 30, 2019
wolfstudy pushed a commit that referenced this pull request Nov 20, 2019
@rdhabalia @wolfstudy
[pulsar-broker] fix broken custom auth-provider that uses authenticat…
4f247a4 
…ionData (#5462)

Fix broken custom auth-provider that uses authenticationData

(cherry picked from commit ebaf97c)
@michaeljmarshall michaeljmarshall mentioned this pull request Sep 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@jiazhai jiazhai jiazhai approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@rdhabalia rdhabalia

Labels
area/broker
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rdhabalia @wolfstudy @jiazhai @sijie @codelipenghui