Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsar-broker] fix broken custom auth-provider that uses authenticationData #5462

Merged
merged 1 commit into from Oct 30, 2019

Conversation

@rdhabalia
Copy link
Contributor

rdhabalia commented Oct 24, 2019

Motivation

with #3677, ServerCnx is not storing client's authenticationData which is used by custom authorization provider and it always receives authenticationData as null and custom auth-provider fails with authorization.

@rdhabalia rdhabalia added this to the 2.4.2 milestone Oct 24, 2019
@rdhabalia rdhabalia self-assigned this Oct 24, 2019
@wolfstudy wolfstudy requested review from sijie and jiazhai Oct 28, 2019
@wolfstudy

This comment has been minimized.

Copy link
Member

wolfstudy commented Oct 28, 2019

@sijie
sijie approved these changes Oct 28, 2019
@wolfstudy

This comment has been minimized.

Copy link
Member

wolfstudy commented Oct 28, 2019

run java8 tests

@jiazhai

This comment has been minimized.

Copy link
Contributor

jiazhai commented Oct 28, 2019

@rdhabalia Thanks for this fix.

@wolfstudy

This comment has been minimized.

Copy link
Member

wolfstudy commented Oct 28, 2019

org.apache.pulsar.broker.admin.AdminApiOffloadTest.testOffloadV1

run java8 tests

@wolfstudy

This comment has been minimized.

Copy link
Member

wolfstudy commented Oct 29, 2019

org.apache.pulsar.functions.worker.PulsarFunctionE2ESecurityTest.testAuthorizationWithAnonymousUser

run java8 tests

@wolfstudy

This comment has been minimized.

Copy link
Member

wolfstudy commented Oct 29, 2019

run java8 tests

@wolfstudy

This comment has been minimized.

Copy link
Member

wolfstudy commented Oct 30, 2019

run java8 tests

@wolfstudy wolfstudy merged commit ebaf97c into apache:master Oct 30, 2019
3 checks passed
3 checks passed
Jenkins: C++ / Python Tests SUCCESS
Details
Jenkins: Integration Tests SUCCESS
Details
Jenkins: Java 8 - Unit Tests SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.