Efficiency improvements for delay delivery tracker #5498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
jerrypeng
approved these changes
Oct 29, 2019
|
run cpp tests |
|
rerun cpp tests |
wolfstudy
pushed a commit
that referenced
this pull request
Nov 20, 2019
Efficiency improvements for delay delivery tracker (cherry picked from commit 467ffab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improved the delayed messages tracker to avoid scheduling the timer more frequently than intended.
Since we group messages in based on
tickTimeMillis, the tracker will yield messages slightly before than when they're about to expire. This is by design. However the problem lies in that the messages are set to be dispatched and then they re-enter on the tracker (for the remained on the delay time, eg. < 1sec).We should avoid re-inserting in the tracker since it's just wasted CPU time.
Also, check the less expensive
delayedDeliveryTracker.hasMessageAvailable()before going to the full blowndelayedDeliveryTracker.getScheduledMessages()