Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list non-persistent topics shows the persistent topics #5502

Merged
merged 2 commits into from Nov 1, 2019

Conversation

@zymap
Copy link
Contributor

zymap commented Oct 30, 2019


Fixes #5414

Motivation

When using the REST API to request to list all the non-persistent
topics, it will show the persistent topics.

Modifications

  • Add a filter when before sending the response
---

Fixes #5414

*Motivation*

When using the REST API to request to list all the non-persistent
topics, it will show the persistent topics.

*Modifications*

- Add a filter when before sending the response
Copy link
Contributor

codelipenghui left a comment

Please add some unit tests to verify this change

@zymap

This comment has been minimized.

Copy link
Contributor Author

zymap commented Oct 30, 2019

@codelipenghui Sure. Test coming soon.

@zymap

This comment has been minimized.

Copy link
Contributor Author

zymap commented Oct 30, 2019

@codelipenghui Added a test. PTAL. Thanks

@zymap

This comment has been minimized.

Copy link
Contributor Author

zymap commented Oct 31, 2019

2019-10-30\T\12:35:49.576 [ERROR] allSchemasShouldRoundtripInput(org.apache.pulsar.client.impl.schema.PrimitiveSchemaTest) Time elapsed: 0.023 s <<< FAILURE!
java.lang.NullPointerException
at java.lang.String.getBytes(String.java:940)
at org.apache.pulsar.client.impl.schema.StringSchema.encode(StringSchema.java:101)
at org.apache.pulsar.client.impl.schema.StringSchema.encode(StringSchema.java:37)
at org.apache.pulsar.client.impl.schema.PrimitiveSchemaTest.allSchemasShouldRoundtripInput(PrimitiveSchemaTest.java:110)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:124)
at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

2019-10-30\T\12:35:49.582 [ERROR] allSchemasShouldSupportNull(org.apache.pulsar.client.impl.schema.PrimitiveSchemaTest) Time elapsed: 0.002 s <<< FAILURE!
java.lang.NullPointerException
at org.apache.pulsar.client.impl.schema.PrimitiveSchemaTest.allSchemasShouldSupportNull(PrimitiveSchemaTest.java:95)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:124)
at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

@zymap

This comment has been minimized.

Copy link
Contributor Author

zymap commented Oct 31, 2019

run java8 tests

1 similar comment
@zymap

This comment has been minimized.

Copy link
Contributor Author

zymap commented Oct 31, 2019

run java8 tests

@sijie
sijie approved these changes Oct 31, 2019
@sijie

This comment has been minimized.

Copy link
Contributor

sijie commented Oct 31, 2019

@sijie sijie added this to the 2.4.2 milestone Oct 31, 2019
@wolfstudy wolfstudy merged commit 79f4710 into apache:master Nov 1, 2019
3 checks passed
3 checks passed
Jenkins: C++ / Python Tests SUCCESS
Details
Jenkins: Integration Tests SUCCESS
Details
Jenkins: Java 8 - Unit Tests SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.