Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix repeated initialization of connectorsManager #5545

Merged
merged 1 commit into from
Nov 3, 2019
Merged

fix repeated initialization of connectorsManager #5545

merged 1 commit into from
Nov 3, 2019

Conversation

kevenYLi
Copy link
Contributor

@kevenYLi kevenYLi commented Nov 3, 2019

Motivation

  • The connectorsManager is initialized twice in WorkerService, it seems to be a misoperation when merging codes.

Modifications

  • Delete the redundant codes.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: ( no)
  • The wire protocol: ( no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

@kevenYLi
fix repeated initialization of connectorsManager
d603d41 
Signed-off-by: KevenYLi <liyi.changde@gmail.com>
@kevenYLi
Copy link
Contributor Author

kevenYLi commented Nov 3, 2019

run cpp tests
run java8 tests
run integrations tests

@aahmed-se aahmed-se requested a review from sijie November 3, 2019 07:33
@kevenYLi
Copy link
Contributor Author

kevenYLi commented Nov 3, 2019

run java8 tests

@sijie
Copy link
Member

sijie commented Nov 3, 2019

run java8 tests

@sijie sijie added area/function type/bug The PR fixed a bug or issue reported a bug labels Nov 3, 2019
@sijie sijie added this to the 2.4.2 milestone Nov 3, 2019
@sijie sijie merged commit 7275d53 into apache:master Nov 3, 2019
@kevenYLi kevenYLi deleted the fix_repeated_initialization_of_connectorsManager branch November 3, 2019 14:18
wolfstudy pushed a commit that referenced this pull request Nov 20, 2019
@kevenYLi @wolfstudy
fix repeated initialization of connectorsManager (#5545)
6b8591c 
### Motivation

- The connectorsManager is initialized twice in WorkerService, it seems to be a misoperation when merging codes. 

### Modifications

- Delete the redundant codes.

(cherry picked from commit 7275d53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@aahmed-se aahmed-se aahmed-se approved these changes

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

Assignees

@aahmed-se aahmed-se

@kevenYLi kevenYLi

Labels
area/function type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevenYLi @sijie @aahmed-se