Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix create consumer on partitioned topic while disable topic auto creation. #5572
Currently, disable the topic auto creation will cause consumer create failed on a partitioned topic. Since the partitioned topic is already created, so we should handle the topic partition create when disable the topic auto creation.
By default, create partitioned topics also try to create all partitions, and if create partitions failed, users can use
If users already have a partitioned topic without created partitions, can also use
Verifying this change
Add new unit tests for this change
Does this pull request potentially affect one of the following parts:
sijie left a comment
I don't think that is the right fix for this problem. The purpose of disabling topic auto-creation is to prevent consumers and producers creating topics.
I think the correct fix should be improving the pulsar-admin tool to create and delete partitions when creating or updating a partitioned topic.
1 similar comment
3 similar comments
it can move to 2.5.1 if 2.5.0 branch will start cut soon. Sijie Guo <email@example.com>于2019年11月26日 周二04:57写道：…
@codelipenghui <https://github.com/codelipenghui> are you going to include this fix in 2.5.0 or shall we move it to 2.5.1 or 2.6.0? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5572?email_source=notifications&email_token=ADACIBNEFVHYYSH7LBLXYSLQVQ35BA5CNFSM4JJSNE2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFDYW6Q#issuecomment-558336890>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADACIBNF3KJK4F5B2MUDI3DQVQ35BANCNFSM4JJSNE2A> .
1 similar comment