[issues 5698]Handle replicator producer as generated name producer #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Nov 19, 2019
| @@ -316,6 +316,11 @@ private void tryOverwriteOldProducer(Producer oldProducer, Producer newProducer) | |||
| } | |||
| } | |||
|
|
|||
| private boolean isUserProvidedProducerName(Producer producer){ | |||
| //considered replicator producer as generated name producer | |||
| return producer.isUserProvidedProducerName() && !producer.getProducerName().startsWith(replicatorPrefix); | |||
There was a problem hiding this comment.
seems 2 space here, please keep 1 space
| topic.removeProducer(producer4); | ||
| Assert.assertEquals(topic.getProducers().size(), 0); | ||
|
|
||
| Producer producer5= new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1", |
There was a problem hiding this comment.
add space before =, please also check other places
|
run java8 tests |
sijie
approved these changes
Nov 19, 2019
| topic.removeProducer(producer4); | ||
| Assert.assertEquals(topic.getProducers().size(), 0); | ||
|
|
||
| Producer producer5= new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1", |
There was a problem hiding this comment.
Suggested change
| Producer producer5= new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1", | |
| Producer producer5 = new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1", |
| topic.addProducer(producer5); | ||
| Assert.assertEquals(topic.getProducers().size(), 1); | ||
|
|
||
| Producer producer6= new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1", |
There was a problem hiding this comment.
Suggested change
| Producer producer6= new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1", | |
| Producer producer6 = new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1", |
|
|
||
| topic.getProducers().values().forEach(producer -> Assert.assertEquals(producer.getEpoch(), 2)); | ||
|
|
||
| Producer producer7= new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1", |
There was a problem hiding this comment.
Suggested change
| Producer producer7= new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1", | |
| Producer producer7 = new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1", |
| @@ -316,6 +316,11 @@ private void tryOverwriteOldProducer(Producer oldProducer, Producer newProducer) | |||
| } | |||
| } | |||
|
|
|||
| private boolean isUserProvidedProducerName(Producer producer){ | |||
| //considered replicator producer as generated name producer | |||
| return producer.isUserProvidedProducerName() && !producer.getProducerName().startsWith(replicatorPrefix); | |||
There was a problem hiding this comment.
Suggested change
| return producer.isUserProvidedProducerName() && !producer.getProducerName().startsWith(replicatorPrefix); | |
| return producer.isUserProvidedProducerName() && !producer.getProducerName().startsWith(replicatorPrefix); |
added 2 commits
November 20, 2019 09:40
weishuisheng
force-pushed
the
issues-5698
branch
from
8258e51
to
2e60c48
Compare
|
run java8 tests |
|
run java8 tests |
|
run integration tests |
sijie
approved these changes
Nov 20, 2019
jiazhai
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5698
Motivation
Since #5571 handle the generated producer name, the replicator producer was created by broker, only one producer for a replicated topic.
So, we can handle it simple by considered replicator producer as generated name producer.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changes